Wireshark-commits: [Wireshark-commits] master 5721a87: Qt: clear Export Objects list on retapping
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Dec 2016 11:26:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5721a87330f8afe3fed12d4af250d7a3d219cbe2
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5721a87 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: clear Export Objects list on retapping
    
    The tap reset callback should not just invoke the reset callback of the
    dissector, but also clear the previous list of objects in the dialog.
    Otherwise duplicate entries will be created every time retapping occurs
    (e.g. on changing the display filter).
    
    Bug: 12230
    Change-Id: I75f25db0652dcc9c0ac59ab0e536c06874aedb9c
    Reviewed-on: https://code.wireshark.org/review/19055
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  40ebfb9   ssh: fix the heuristic for MAC size determination
    adds  5721a87   Qt: clear Export Objects list on retapping


Summary of changes:
 ui/qt/export_object_dialog.cpp |    3 +++
 1 file changed, 3 insertions(+)