Wireshark-commits: [Wireshark-commits] master 77f31c6: packet-infiniband: Fixed duplicate conversat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 3 Dec 2016 13:24:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77f31c6e7de5baed978298ae599494255fe254da
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

77f31c6 by Parav Pandit (paravpandit@xxxxxxxxx):

    packet-infiniband: Fixed duplicate conversation entries
    
    1. Fixed find_conversation for PT_IBQP to not lookup in reverse
    direction when all searches fail.
    This is required, because there could be valid different connection in
    reverse direction which mistakenly gets updated for non template cases.
    
    2. Added support for having MAD data for upper level dissectors to process
    during RC packet processing.
    This is required because connection options are negotiated out of band
    using this CM exchanges (unlike in band TCP options).
    
    3. Moved creating unidirectional connections when actually MAD packets
    are processed.
    Previously client-to-server unidirectional conversation was created when
    CM_RSP stage, where MAD Data of CM_REQ packet is inaccessible.
    
    4. Fixed creating multiple conversations with same address property by
    eliminating create_conv_and_add_proto_data during RTU stage, which was
    incorrect.
    Now they are created during REQ and RSP frame processing. (Instead of
    RSP and RTU processing).
    
    5. Added support for creating bidirectional connection that ULP can
    refer.
    This is required to keep track of oustanding transactions on a
    connection (requests and responses).
    
    Bug: 11363
    Change-Id: I32ea084a581a58efbc16dbb7a3e267c82622c50c
    Tested-by: paravpandit@xxxxxxxxx
    Reviewed-on: https://code.wireshark.org/review/18982
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  50489fd   tshark: Add -G folders report
    adds  77f31c6   packet-infiniband: Fixed duplicate conversation entries


Summary of changes:
 epan/conversation.c                 |   83 +++++++++++++++-------------
 epan/dissectors/packet-infiniband.c |  103 +++++++++++++++++++++++++----------
 epan/dissectors/packet-infiniband.h |    4 ++
 3 files changed, 123 insertions(+), 67 deletions(-)