Wireshark-commits: [Wireshark-commits] master-2.0 eee5f97: packet-rpcrdma: Fix protocol frame pre-d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 3 Dec 2016 00:32:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eee5f975d37f195b6a9173e5ebc14cbadf44567c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

eee5f97 by Chuck Lever (chuck.lever@xxxxxxxxxx):

    packet-rpcrdma: Fix protocol frame pre-detection
    
    The current mechanism of detecting RPC-over-RDMA is broken because
    it treats the Read list as a counted array (it's a list); and treats
    the Write list and Reply chunk identically (one is a list, one is
    always a single chunk).
    
    While we're here, refactor pre-detection helper functions so they
    can be used during frame dissection as well.
    
    Bug: 13196
    Change-Id: I76e210c8d2a9464fed00e7199072d37f4ebbebf2
    Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/19025
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 2462f9e8103b23c2728cc5aa84995e0b2f363f12)
    Reviewed-on: https://code.wireshark.org/review/19045
    

Actions performed:

    from  30c1081   packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA
    adds  eee5f97   packet-rpcrdma: Fix protocol frame pre-detection


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |  127 +++++++++++++++++++++++++++-----------
 1 file changed, 90 insertions(+), 37 deletions(-)