Wireshark-commits: [Wireshark-commits] master 14bae88: packet-rpcrdma: Display length and version f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 2 Dec 2016 21:34:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14bae88e0f7827ccf470704a9b997dfd5e665319
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

14bae88 by Chuck Lever (chuck.lever@xxxxxxxxxx):

    packet-rpcrdma: Display length and version fields in decimal
    
    Display length fields in decimal, just as they are displayed by the
    RDMA RETH dissector.
    
    Display version fields in decimal, just as they are displayed by the
    RPC dissector.
    
    RDMA offset fields are left in hexadecimal since they are
    essentially addresses, and at least the Linux RPC-over-RDMA
    implementation has debugging messages that display these as
    hexadecimal values.
    
    Change-Id: I7206970675ca0ca486b3a2837b6dbb1c4d764091
    Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/19028
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  aecff2f   Include config.h first, for large-file-related #defines.
    adds  14bae88   packet-rpcrdma: Display length and version fields in decimal


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)