Wireshark-commits: [Wireshark-commits] master-2.0 6f64047: Qt: Export object fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 2 Dec 2016 20:09:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6f64047ade14c84caf37c69b55912839a6a15734
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6f64047 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Export object fixups.
    
    Add eo_free_entry, which frees an export_object_entry_t.
    
    Create ExportObjectTreeWidgetItem similar to our other custom
    TreeWidgetItems. Call eo_free_entry in its destructor. This fixes a
    serious memory leak.
    
    Make the columns sortable. Fixup numeric comparisons. Use a convenience
    function for file sizes.
    
    Ping-Bug: 13174
    Change-Id: Idb4eb5680afe760880ebe7d84216fcac5ccdb250
    Reviewed-on: https://code.wireshark.org/review/19010
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit e7042d8af3ead1ff43b48d0a3b669c286c970cb5)
    Reviewed-on: https://code.wireshark.org/review/19021
    

Actions performed:

    from  5dc08c6   Qt: fix crash when closing RTP player while playing
    adds  6f64047   Qt: Export object fixups.


Summary of changes:
 ui/export_object.c             |   10 ++++
 ui/export_object.h             |    1 +
 ui/gtk/export_object_dlg.c     |    8 +--
 ui/qt/export_object_dialog.cpp |  128 ++++++++++++++++++++++++++++++++--------
 ui/qt/export_object_dialog.h   |    5 --
 5 files changed, 117 insertions(+), 35 deletions(-)