Wireshark-commits: [Wireshark-commits] master-2.2 b3613a9: Qt: fix GoToPacket when Voip Calls dialo
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3613a9951ce574b44b7a875b7ce0d3051b94496
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark
Commits:
b3613a9 by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: fix GoToPacket when Voip Calls dialog is closed
After opening the Call Flows dialog from the Voip Calls dialog, followed
by closing the Voip Calls dialog, the Go To Packet functionality in the
Call Flows dialog is broken. That happens because the signal is not
proxied anymore.
Just remove all these indirections via signals and directly update the
selected packet.
Change-Id: I9c6d519dbe800e4dfdf0407d832f17819b344e46
Reviewed-on: https://code.wireshark.org/review/18933
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
(cherry picked from commit 7fe45cc0ec4e8bc1c3d5cd27c98feb8ecbb2b1b4)
Reviewed-on: https://code.wireshark.org/review/18986
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from f844484 2.2 doesn't have FT_CHAR.
adds b3613a9 Qt: fix GoToPacket when Voip Calls dialog is closed
Summary of changes:
ui/qt/sequence_dialog.cpp | 8 +++++---
ui/qt/sequence_dialog.h | 3 ---
ui/qt/voip_calls_dialog.cpp | 3 ---
3 files changed, 5 insertions(+), 9 deletions(-)