Wireshark-commits: [Wireshark-commits] master 7c3aa5a: Qt: Fix conversation buttons.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Nov 2016 19:35:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c3aa5a88ca78bf029fd16aea2a9a1f4861227db
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7c3aa5a by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix conversation buttons.
    
    Move parts of currentTabChanged to conversationSelectionChanged. This
    lets us enable the "Follow Stream" and "Graph" buttons when either the
    current tab or the current selection changes.
    
    Bug: 12893
    Change-Id: I025447d26073a938f2d8b5a8fcad7c0d5e855650
    Reviewed-on: https://code.wireshark.org/review/18963
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  1239336   Qt: fix heap-use-after-free when double-clicking a packet number
    adds  7c3aa5a   Qt: Fix conversation buttons.


Summary of changes:
 ui/qt/conversation_dialog.cpp |   38 +++++++++++++++++++++++---------------
 ui/qt/conversation_dialog.h   |    1 +
 2 files changed, 24 insertions(+), 15 deletions(-)