Wireshark-commits: [Wireshark-commits] master-2.2 d30be94: Qt: fix heap-use-after-free when double-
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Nov 2016 18:07:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d30be948bbbdc353582e14ce110495edc602573c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d30be94 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix heap-use-after-free when double-clicking a packet number
    
    On double-clicking a packet number, the current field item is
    invalidated by goToPacket. Skip the URL since a field can either have a
    URL or a frame number (but not both).
    
    Change-Id: I58e5445fa74071fa0fd203df77ebdecdd1478d31
    Reviewed-on: https://code.wireshark.org/review/18971
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 1239336af00215172c94d5d2af3926a72ea998c3)
    Reviewed-on: https://code.wireshark.org/review/18973
    

Actions performed:

    from  ff7f93b   Fix git description for out-of-tree builds from a tarball
    adds  d30be94   Qt: fix heap-use-after-free when double-clicking a packet number


Summary of changes:
 ui/qt/proto_tree.cpp |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)