Wireshark-commits: [Wireshark-commits] master c551e06: PROFINET: Update LineDelay Dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 Nov 2016 21:42:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c551e06e797577abb688060babf660489b65e800
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c551e06 by Birol Capa (birol.capa@xxxxxxxxxxx):

    PROFINET: Update LineDelay Dissection
    
    When LineDelay is decoded, the FormatIndicator is not evaluted.
    
    Sample LineDelay: 2147483658 (0x80 00 00 0a)
    This value should be 10,
    since FormatIndicator (Bit 31) = 0x01 states that this is a CableDelay.
    
    Change-Id: I08ae8e6de8b6f8c493122109e29e91dc47096734
    Reviewed-on: https://code.wireshark.org/review/18950
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ce90d98   packet-dcm.c: Cleanup memory usage with strings
    adds  c551e06   PROFINET: Update LineDelay Dissection


Summary of changes:
 plugins/profinet/packet-dcerpc-pn-io.c |   75 ++++++++++++++++++++++++++++----
 1 file changed, 67 insertions(+), 8 deletions(-)