Wireshark · Wireshark-commits: [Wireshark-commits] master 975461a: packet-dcm.c: Assorted cleanup

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=975461af4b7dc5a5da02d14f73eee63426ed416d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

975461a by Michael Mann (mmann78@xxxxxxxxxxxx):

    packet-dcm.c: Assorted cleanup
    
    1. Use tvb_get_guintXX with encoding parameter rather than have an "is_little_endian" flag
    2. Replace proto_tree_add_xxx_format with proto_tree_add_xxx_format_value or proto_tree_add_item
    3. Create some value_strings in favor of functions.
    
    Change-Id: If4b8e8992662bda768b39ba5f1932272760eef65
    Reviewed-on: https://code.wireshark.org/review/18909
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  79c2bdc   NAS EPS: fill info column when receiving a ciphered message
    adds  975461a   packet-dcm.c: Assorted cleanup


Summary of changes:
 epan/dissectors/packet-dcm.c |  300 +++++++++++++-----------------------------
 1 file changed, 88 insertions(+), 212 deletions(-)