Wireshark-commits: [Wireshark-commits] master 6bd3222: tcp: fix "calculated checksum" tree item for
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Nov 2016 03:42:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6bd322223d3f13612a449cbba20ce36e9da30ebb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6bd3222 by Alex Badea (abadea@xxxxxxxxxxx):

    tcp: fix "calculated checksum" tree item for bad checksums
    
    The Calculated Checksum tree item prints the checksum from the
    tvb, instead of the computed one  (the "should be 0x...." tree
    item above it _does_ print the computed one).  As such, in a packet
    with bad checksum, the Calculated Checksum is incorrect.  Fix the value.
    
    This seems to have been introduced in ad6fc87d ("Add
    proto_tree_add_checksum.")
    
    Change-Id: Ia20d5addc40956713a944102e79d25317b969a0e
    Reviewed-on: https://code.wireshark.org/review/18859
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  abf802b   Reassemble: fix premature free
    adds  6bd3222   tcp: fix "calculated checksum" tree item for bad checksums


Summary of changes:
 epan/dissectors/packet-tcp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)