Wireshark-commits: [Wireshark-commits] master 58c4a4e: cmake/FindPCAP: fix use of bad cached functi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 18 Nov 2016 17:34:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58c4a4e018a3e1086ccbea773a05fa3f005a1a14
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

58c4a4e by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake/FindPCAP: fix use of bad cached function checks
    
    When libpcap-dev is not installed, do not look for functions like
    pcap_datalink_name_to_val since the negative result would be cached.
    Then after installing libpcap-dev, the build would fail due to
    redeclaration of functions.
    
    Change-Id: Ifdbad09e9cf160383b16b6459693f7ea5d65b9c3
    Reviewed-on: https://code.wireshark.org/review/18834
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  bba62e2   [GSM A RR] Fix dissection of c1_delta.
    adds  58c4a4e   cmake/FindPCAP: fix use of bad cached function checks


Summary of changes:
 cmake/modules/FindPCAP.cmake |   94 +++++++++++++++++++++---------------------
 1 file changed, 48 insertions(+), 46 deletions(-)