Wireshark-commits: [Wireshark-commits] master-2.2 211ff87: BGP: Fix length in decode_prefix4()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 18 Nov 2016 02:30:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=211ff877409240f19382e1a35d78a94f4773fff8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

211ff87 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    BGP: Fix length in decode_prefix4()
    
    When decode_prefix4() gets called with more prefixes the length of
    proto_tree_add_subtree_format() should not be the total length.
    
    As the "Withdrawn route" part was the only one where decode_prefix4() has
    been called with a tlen not equal 0 we can eliminate the tlen parameter.
    
    Bug: 13146
    Change-Id: I708dec2cecbed6054b60190104b82c72d54e8037
    Reviewed-on: https://code.wireshark.org/review/18852
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/18857
    

Actions performed:

    from  0e19e81   2.2.2 → 2.2.3.
    adds  211ff87   BGP: Fix length in decode_prefix4()


Summary of changes:
 epan/dissectors/packet-bgp.c |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)