Wireshark-commits: [Wireshark-commits] master 271ee47: SABP: add support for messages >= 16KB
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Nov 2016 09:41:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=271ee471ddc801dc89b3c7953f4f2bcff75ffa83
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

271ee47 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SABP: add support for messages >= 16KB
    
    Because of the way PER specification encodes length determinant >= 16K,
    we cannot get the PDU length from a fixed position at the beginning of
    the message. So drop tcp_dissect_pdus() (that cannot work for this use
    case) and manually request extra chunks until the full PDU is available.
    
    Bug: 8221
    Change-Id: I91e32160fc2180f74b3edb9699ba510798b46983
    Reviewed-on: https://code.wireshark.org/review/18808
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c88b8ad   PER: add support for fragmented open type
    adds  271ee47   SABP: add support for messages >= 16KB


Summary of changes:
 epan/dissectors/asn1/sabp/packet-sabp-template.c |   71 ++++++++++---------
 epan/dissectors/packet-sabp.c                    |   79 +++++++++++-----------
 2 files changed, 74 insertions(+), 76 deletions(-)