Wireshark-commits: [Wireshark-commits] master-2.2 5a45dd2: Qt: populate Bookmarks menu in capture o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Nov 2016 04:14:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a45dd2a36dae88122d650a26eb76873b35e4e54
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

5a45dd2 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: populate Bookmarks menu in capture options dialog
    
    The bookmarks menu is populated for the main window when the
    appInitialized signal is emitted, this ensures that any preferences are
    applied.
    
    For the Capture Options dialog however, the appInitialized signal is
    never triggered since the GUI has already started. Just invoke it from
    the constructor such the menu is populated at least once.
    
    Bug: 12986
    Change-Id: I04457fd25e52a25714ac471131b90e3a128515d8
    Reviewed-on: https://code.wireshark.org/review/18734
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit efe95fa8fd79d4c087ce587143c000dd61218bc0)
    Reviewed-on: https://code.wireshark.org/review/18761
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  528d2e6   Allocate transport_info->encoding_name from correct memory pool
    adds  5a45dd2   Qt: populate Bookmarks menu in capture options dialog


Summary of changes:
 ui/qt/capture_filter_edit.cpp |    1 +
 1 file changed, 1 insertion(+)