Wireshark-commits: [Wireshark-commits] master 66fa314: tcp: Fix Follow TCP tap data and when its ta
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 10 Nov 2016 20:48:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66fa31415ff8d520c71dc66718599e941ed05c29
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

66fa314 by Michael Mann (mmann78@xxxxxxxxxxxx):

    tcp: Fix Follow TCP tap data and when its tapped.
    
    Use the model from the 2.0 branch and earlier that only "tapped" the
    follow data in a single location. This fixes duplicate data for
    reassembled data and handles out-of-order packets.
    
    Bug: 12855
    Change-Id: I5268f13e3c08e9271acf026b859de693ad794c94
    Reviewed-on: https://code.wireshark.org/review/18368
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  b489b7f   lsd: fix unaligned read
    adds  66fa314   tcp: Fix Follow TCP tap data and when its tapped.


Summary of changes:
 debian/libwireshark0.symbols   |    1 +
 epan/dissectors/packet-tcp.c   |  263 +++++++++++++++++++++++++++++++++++-----
 epan/follow.c                  |   41 +++++++
 epan/follow.h                  |   10 ++
 ui/cli/tap-follow.c            |    3 +-
 ui/gtk/follow_stream.c         |   17 +--
 ui/qt/follow_stream_dialog.cpp |   24 +++-
 7 files changed, 309 insertions(+), 50 deletions(-)