Wireshark-commits: [Wireshark-commits] master 5ae9af9: Get rid of Boolean "flags" that don't have a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Nov 2016 19:03:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ae9af9e50c89d8700e5a166a9c345fc46b3a4ca
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5ae9af9 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of Boolean "flags" that don't have any bit set.
    
    And tweak the Pidl generator for Wireshark not to generate "flags" like
    that.
    
    (The generator also does field name and true/false strings' case
    differently, so I didn't use it to regenerate the dissectors; that needs
    to be looked at.)
    
    Change-Id: Ie1657a782ebdb107e58792cedd29bbaa79b17bd4
    Reviewed-on: https://code.wireshark.org/review/18695
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a5a179d   Use guint rather than gsize, to avoid 64-bit-to-32-bit shortening warnings.
    adds  5ae9af9   Get rid of Boolean "flags" that don't have any bit set.


Summary of changes:
 epan/dissectors/packet-dcerpc-eventlog.c   |    8 --------
 epan/dissectors/packet-dcerpc-witness.c    |    8 --------
 tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm |   29 ++++++++++++++++------------
 3 files changed, 17 insertions(+), 28 deletions(-)