Wireshark-commits: [Wireshark-commits] master 94b923c: gsm_abis_pgsl: Hand off into GPRS RLC/MAC di
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Nov 2016 18:04:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94b923c11b6afc5f2ad7ee5a1f27c7fc514b4540
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

94b923c by Harald Welte (laforge@xxxxxxxxxxxx):

    gsm_abis_pgsl: Hand off into GPRS RLC/MAC dissector
    
    Rather than displaying the P-GSL data as "data", let's call the
    proper GPRS RLC/MAC dissector to get a decode of the payload.
    
    As the RLC/MAC payload of P-GSL is one un-aligned stream of bits
    containing the EGPRS header + RLC data blocks, we need to re-aling the
    data blocks before calling into the RLC/MAC dissector in case of EGRPS.
    
    Change-Id: Ib081606c1b7af2a15ecf3c5f5b3ff44b5096e865
    Reviewed-on: https://code.wireshark.org/review/18483
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  37388fb   gsm_abis_pgsl: Dissect Uplink Channel Mode Information Element
    adds  94b923c   gsm_abis_pgsl: Hand off into GPRS RLC/MAC dissector


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |  229 ++++++++++++++++++++++++++++++--
 1 file changed, 220 insertions(+), 9 deletions(-)