Wireshark-commits: [Wireshark-commits] master-2.2 2b4f018: RTS_FLAG_NONE is a flags field value, bu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Nov 2016 01:59:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2b4f018fa398626e0656703803e0a6d25e8f3da2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2b4f018 by Guy Harris (guy@xxxxxxxxxxxx):

    RTS_FLAG_NONE is a flags field value, but it's not a flag bit.
    
    It's the *absence* of flag bits, so you can't test whether it's set;
    don't have a field for it.  This gets rid of a dissector assertion.
    
    Add some more URLs for information about DCE RPC and MS-RPC.
    
    Change-Id: I53e8f11692c66e16ae2ec7fd4ba8eb90b0673da4
    Reviewed-on: https://code.wireshark.org/review/18648
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit eb56b7172d33605cbb969afd91beb302f89013ed)
    Reviewed-on: https://code.wireshark.org/review/18649
    

Actions performed:

    from  9235611   proto: Decode negative values in a bitmask field
    adds  2b4f018   RTS_FLAG_NONE is a flags field value, but it's not a flag bit.


Summary of changes:
 epan/dissectors/packet-dcerpc.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)