Wireshark-commits: [Wireshark-commits] master-2.0 3518e8d: SNA: fix dissection of GDS Variables
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Nov 2016 17:48:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3518e8dc4be5810b6c75665ed1cc65102ae41d2a
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3518e8d by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SNA: fix dissection of GDS Variables
    
    Decode the header as specified in http://www.retrocomputing.net/info/doc/GA27-3136-20_SNA_Formats.pdf chapter 13.
    Note that the Information field is not decoded yet.
    
    Bug: 13084
    Change-Id: Iaaee344ef0b2805906a3eeae1134479abf9d403e
    Reviewed-on: https://code.wireshark.org/review/18616
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 2a651cfc663b87dca4a526a71724b13fb45091cf)
    Reviewed-on: https://code.wireshark.org/review/18625
    

Actions performed:

    from  de435fe   make-version: Clean up handling of VCSVERSION
    adds  3518e8d   SNA: fix dissection of GDS Variables


Summary of changes:
 epan/dissectors/packet-sna.c |   37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)