Wireshark-commits: [Wireshark-commits] master 0f2f66d: Fix some errors.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Nov 2016 08:44:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0f2f66dee929250af4c39eded6c048c4922fd942
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0f2f66d by Guy Harris (guy@xxxxxxxxxxxx):

    Fix some errors.
    
    Th link throughput and latency objects are just 32-bit integers; process
    them as such and, as they're bytes-per-second and microsecond values,
    respectively, show them as decimal, rather than as hex, as most of us
    have 10, not 16, fingers.
    
    The ETX metric object is a 16-bit integer; process it as such, and show
    it in decimal as well.
    
    Attach an expert info representing an error to the item in error.
    
    Change-Id: I57dfac0127d263724cc6940a0457d63e17616b64
    Reviewed-on: https://code.wireshark.org/review/18617
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5ec8186   Add snappy compression library setup
    adds  0f2f66d   Fix some errors.


Summary of changes:
 epan/dissectors/packet-icmpv6.c |   56 +++++----------------------------------
 1 file changed, 7 insertions(+), 49 deletions(-)