Wireshark-commits: [Wireshark-commits] master f184dff: sip: fix Authorization header with mixed quo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 30 Oct 2016 08:50:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f184dff8763b4145fa786fe57d0ae541375e9dc0
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f184dff by erikdejong (erikdejong@xxxxxxxxx):

    sip: fix Authorization header with mixed quoted parameters
    
    Fix to correctly read unquoted parameter values in Authorization lines.
    Code in master branch will look for double quotes as the end of a
    parameter value even in case the value is not enclosed in double quotes.
    This fix checks if the first character in a value is a double quote in
    which case it will scan until a non-escaped finishing double quote is
    found to determine the end of the value string. If no double quote is
    found as the start of the parameter value it will scan for a comma as
    the end of the value string.
    
    Change-Id: I5322caa146d3213bc94ad24528c2fa23cdea10f2
    Bug: 13035
    Reviewed-on: https://code.wireshark.org/review/18344
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  c9b5b6c   hpfeeds: restore channel name in tree.
    adds  f184dff   sip: fix Authorization header with mixed quoted parameters


Summary of changes:
 epan/dissectors/packet-sip.c |   49 +++++++++++++++++++++++++-----------------
 1 file changed, 29 insertions(+), 20 deletions(-)