Wireshark-commits: [Wireshark-commits] master 6500a66: ManageInterfacesDialog: New handling of pipe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Oct 2016 23:54:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6500a660c2285aa558be58b084de9554fccdfc09
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6500a66 by Roland Knall (rknall@xxxxxxxxx):

    ManageInterfacesDialog: New handling of pipes
    
    This moves the handling of pipes to the new InterfaceTreeModel as well.
    It also includes a new PathChooserDelegate and cache handling for adding
    data to an interface list without putting it into storage
    
    Change-Id: Id255a81161b4da517e26127abe8ea7f5eb36d55a
    Reviewed-on: https://code.wireshark.org/review/18497
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  1fae142   merge.c: do not give a NULL pointer when saving SHB comment option
    adds  6500a66   ManageInterfacesDialog: New handling of pipes


Summary of changes:
 ui/qt/CMakeLists.txt                               |    2 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/interface_sort_filter_model.cpp              |   26 +-
 ui/qt/interface_sort_filter_model.h                |    1 +
 ui/qt/interface_tree_cache_model.cpp               |  247 ++++++++++++++++---
 ui/qt/interface_tree_cache_model.h                 |   10 +
 ui/qt/interface_tree_model.cpp                     |   10 +-
 ui/qt/interface_tree_model.h                       |    1 +
 ui/qt/manage_interfaces_dialog.cpp                 |  249 ++++----------------
 ui/qt/manage_interfaces_dialog.h                   |   32 +--
 ui/qt/manage_interfaces_dialog.ui                  |    7 +-
 ui/qt/path_chooser_delegate.cpp                    |  152 ++++++++++++
 ...parkline_delegate.h => path_chooser_delegate.h} |   32 ++-
 13 files changed, 487 insertions(+), 284 deletions(-)
 create mode 100644 ui/qt/path_chooser_delegate.cpp
 copy ui/qt/{sparkline_delegate.h => path_chooser_delegate.h} (63%)