Wireshark · Wireshark-commits: [Wireshark-commits] master 41c4cd8: packet-infiniband: Add support to sub dissect CM messages privat

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41c4cd81a5fdba2b88817c1fa60fc64f6dc1c272
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

41c4cd8 by Parav Pandit (paravpandit@xxxxxxxxx):

    packet-infiniband: Add support to sub dissect CM messages private data
    
    1. This patch enables sub dissectors to parse RTU, REJ,
    DREQ, DRSP CM messages private data.
    (Sub dissection for CM REQ and RSP private data was
    already present).
    
    2. For dissecting non CM data specific packets, connection
    context needs to be active until connection is closed. So instead of
    removing hash table entry during CM response message,
    it keeps it around until DRSP (when connection is closed).
    
    3. This patch moves CM messsage dissection to their individual
    functions for cleanup, so that main parser remains readable code.
    
    4. created smaller functions for reusing in different message parsing
    functions.
    
    REQ, RSP, DREQ, DRSP message are tested.
    REJ is untested.
    
    Change-Id: I3b4695402d1dbe93fc003d4b43424ae0aa96ba43
    Tested-by: paravpandit@xxxxxxxxx
    Reviewed-on: https://code.wireshark.org/review/18469
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  d0bb041   Add support to dissect iperf2 packets
    adds  41c4cd8   packet-infiniband: Add support to sub dissect CM messages private data


Summary of changes:
 epan/dissectors/packet-infiniband.c |  275 ++++++++++++++++++++++++-----------
 1 file changed, 188 insertions(+), 87 deletions(-)