Wireshark-commits: [Wireshark-commits] master 3b502c8: Qt: fix possible crash on sorting custom col
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Oct 2016 04:33:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b502c873f2b30e661d46693d3a3f6fcba9474ea
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3b502c8 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix possible crash on sorting custom columns
    
    The sorting function must maintain a strict weak ordering, otherwise it
    may result in crashes. In the case of custom columns, this was violated
    when exactly one of the two rows had a non-numeric value.
    
    Bug: 13023
    Change-Id: Ie338b1cce5156eeb313dd33491ee3d3f2eaddf1c
    Reviewed-on: https://code.wireshark.org/review/18406
    Reviewed-by: Jim Young <jim.young.ws@xxxxxxxxx>
    Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
    Tested-by: Jim Young <jim.young.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  20e2edc   Add some Diameter AVPs referenced by (recently added) grouped AVPs.
    adds  3b502c8   Qt: fix possible crash on sorting custom columns


Summary of changes:
 ui/qt/packet_list_model.cpp |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)