Wireshark-commits: [Wireshark-commits] master-2.2 ce6e29b: On UN*X, st_ctime is the last status cha
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Oct 2016 08:28:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce6e29bf94d2982c65f6bb03c6bcba555de701ed
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ce6e29b by Guy Harris (guy@xxxxxxxxxxxx):

    On UN*X, st_ctime is the last status change time, not the creation time.
    
    That's the time the file's inode last changed, so size changes,
    permission changes, etc. affect it.  It's *not* the time the file was
    created; most UN*Xes don't provide that.  Newer versions of FreeBSD,
    NetBSD, OpenBSD, and macOS do, but other UN*Xes don't appear to.
    
    On Windows, at least according to Microsoft's documentation, st_ctime
    *is* the creation time.  Hopefully that's not the result of confusion on
    the part of somebody at Microsoft.
    
    Change-Id: I20743703f6ef66e40dff9004dc91bed46af6fad0
    Reviewed-on: https://code.wireshark.org/review/18378
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 528894e72f973c5db5dc76c975620754f7bbe5aa)
    Reviewed-on: https://code.wireshark.org/review/18380
    

Actions performed:

    from  31e1149   Suppress "discarding const" warning.
    adds  ce6e29b   On UN*X, st_ctime is the last status change time, not the creation time.


Summary of changes:
 ConfigureChecks.cmake     |    8 +++++---
 cmakeconfig.h.in          |    6 ++++++
 configure.ac              |    6 ++++++
 fileset.c                 |   24 ++++++++++++++++++++++++
 ui/gtk/fileset_dlg.c      |   28 +++++++++++++++++++---------
 ui/qt/file_set_dialog.cpp |   14 ++++++++++++--
 6 files changed, 72 insertions(+), 14 deletions(-)