Wireshark-commits: [Wireshark-commits] master-2.2 926711c: Fix bin2hex().
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Oct 2016 22:13:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=926711c416636c2531f9e36999c506500fdd7224
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

926711c by Guy Harris (guy@xxxxxxxxxxxx):

    Fix bin2hex().
    
    It was repeatedly overwriting the first character in the buffer, rather
    than appending characters.
    
    Change-Id: Ie34d194d69ac3d685416323c93764aa401d78faa
    Reviewed-on: https://code.wireshark.org/review/18209
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 74174367ff72257a7bd485f9a48c3c3667bd8e3b)
    Reviewed-on: https://code.wireshark.org/review/18210
    

Actions performed:

    from  ccd0987   Append Integer32 value to varbind also.
    adds  926711c   Fix bin2hex().


Summary of changes:
 epan/dissectors/packet-iso8583.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)