Wireshark-commits: [Wireshark-commits] master-2.2 ccd0987: Append Integer32 value to varbind also.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Oct 2016 16:23:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ccd098701cf79abd21d9d70cd5b1cecaf24f1cb9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ccd0987 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Append Integer32 value to varbind also.
    
    Integer32 is handled slightly different from other values, but
    that doesn't mean its pi_value shouldn't be saved to add to the
    varbind later on.
    
    Bug: 13013
    Change-Id: I6789a75ffd3bb95b7dd68f9cb356dbd85fc669d4
    Reviewed-on: https://code.wireshark.org/review/18189
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    (cherry picked from commit db690aa4444322d85f40ecef7892ec12b3e423b9)
    Reviewed-on: https://code.wireshark.org/review/18203
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f44319f   Retrieve CLNP option values from the right place
    adds  ccd0987   Append Integer32 value to varbind also.


Summary of changes:
 epan/dissectors/asn1/snmp/packet-snmp-template.c |    2 +-
 epan/dissectors/packet-snmp.c                    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)