Wireshark-commits: [Wireshark-commits] master 3a08906: Retrieve CLNP option values from the right p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Oct 2016 13:34:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a08906ca7c1e66037977f0e701af6a7c89bd4f9
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3a08906 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Retrieve CLNP option values from the right place
    
    Use proper offsets when getting and presenting option values
    for error reports. Limit the use of the error position
    highlighting feature to 'field' only.
    
    Bug: 12993
    Change-Id: Ie9d6644203cf849dbb8efe15e87249a3aace3b5c
    Reviewed-on: https://code.wireshark.org/review/18195
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  db690aa   Append Integer32 value to varbind also.
    adds  3a08906   Retrieve CLNP option values from the right place


Summary of changes:
 epan/dissectors/packet-osi-options.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)