Wireshark-commits: [Wireshark-commits] master 4d8581d: CIP: Improve string handling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 13 Oct 2016 02:14:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d8581d7e15fe4a80a53496b83a853271fc674b6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4d8581d by D. Ulis (daulis0@xxxxxxxxx):

    CIP: Improve string handling
    
    1. Add support for STRINGI
    2. Add File Name attribute that is a STRINGI
    3. CCO Get/Set Attr All: Connection Name is STRING2 not ASCII
    4. TCP/IP Host Name attribute is not just a STRING. It also needs a pad byte.
    5. Minor: Fix byte highlighting for CCO I/O Mapping tree
    6. Minor: All back byte highlighting for Get Attr All Rsp individual attributes
    
    Change-Id: Ib10d6f2e86e39e8cd6335dc6b6dbebbd1c4d8e64
    Reviewed-on: https://code.wireshark.org/review/18166
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  464e6cd   .mailmap: fix typo
    adds  4d8581d   CIP: Improve string handling


Summary of changes:
 epan/dissectors/packet-cip.c  |  165 ++++++++++++++++++++++++++++-------------
 epan/dissectors/packet-cip.h  |   11 ++-
 epan/dissectors/packet-enip.c |   14 +++-
 3 files changed, 136 insertions(+), 54 deletions(-)