Wireshark-commits: [Wireshark-commits] master dd589f5: Qt: valign text in RTP Stream Analysis windo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 7 Oct 2016 22:50:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd589f5c169f0d9feb55d86d4bc3fe3b991ea822
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dd589f5 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Qt: valign text in RTP Stream Analysis window.
    
    The text on the left hand side of the RTP Stream Analtsis window is
    a (HTML) table of table headers followed by table data. For some reason
    the table data is center aligned in the cells of the table. This does not
    line up with the text in the table header cells.
    
    See http://imgur.com/a/QIQFd
    
    Also the HTML document is not compliant. Closing tags are missing, for
    td and html itself.
    
    Change-Id: I1cd58e8702db12433c863757141a6b68c1e2550c
    Reviewed-on: https://code.wireshark.org/review/18074
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  41fe95f   [MEGACO] Add long name for gm/rsb
    adds  dd589f5   Qt: valign text in RTP Stream Analysis window.


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp |   48 ++++++++++++++++++++---------------------
 1 file changed, 24 insertions(+), 24 deletions(-)