Wireshark-commits: [Wireshark-commits] master d58da8e: Interface View/Model: Correct column orderin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 7 Oct 2016 14:31:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d58da8ec9098f249abd3fd0dfb3e00dee6ff47b4
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d58da8e by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    Interface View/Model: Correct column ordering
    
    This orders the columns correctly in the sequence the developer
    has intended when adding them with setColumns. Also it allows for
    disabling and inverting the filtering by type, as well as query
    additional roles instead of only Qt::DisplayRole from the tree model.
    
    Change-Id: I90469e8e3f3caa50debb3c839590d42719a6fb10
    Reviewed-on: https://code.wireshark.org/review/18096
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a239472   rtsp: use ws_strto[u|i] functions.
    adds  d58da8e   Interface View/Model: Correct column ordering


Summary of changes:
 ui/qt/interface_frame.cpp             |   15 ++++------
 ui/qt/interface_sort_filter_model.cpp |   52 +++++++++++++++++++++++++++++----
 ui/qt/interface_sort_filter_model.h   |    7 +++++
 ui/qt/interface_tree_model.cpp        |    4 +--
 ui/qt/interface_tree_model.h          |    2 +-
 5 files changed, 63 insertions(+), 17 deletions(-)