Wireshark-commits: [Wireshark-commits] master 064f4d1: eap: dissect eap wlan identity.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Sep 2016 04:33:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=064f4d18dbc2cba6452d69bd354da2ff234b4182
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

064f4d1 by Dario Lombardo (lomato@xxxxxxxxx):

    eap: dissect eap wlan identity.
    
    EAP identities can be of different kind. This change adds a sort
    of heuristic that dissects the wlan identity in the form of
    <imsi>@wlan.mnc<mnc>.mcc<mcc>.3gppnetwork.org. A general purpose
    dissection function, acting as a proxy, has been created to make
    room for other specific dissections.
    
    Bug: 12921
    Change-Id: Ic48aee004fa7df5ee4dbeca091ed31616d155890
    Reviewed-on: https://code.wireshark.org/review/17796
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1ec28b4   packet-dcerpc: let dissect_dcerpc_cn_auth() always dissect the whole auth_info
    adds  064f4d1   eap: dissect eap wlan identity.


Summary of changes:
 epan/dissectors/packet-e212.c |    2 +-
 epan/dissectors/packet-e212.h |    2 +
 epan/dissectors/packet-eap.c  |  143 ++++++++++++++++++++++++++++-------------
 3 files changed, 102 insertions(+), 45 deletions(-)