Wireshark-commits: [Wireshark-commits] master 39c3ddf: Fix handling of EAP identity.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 Sep 2016 20:15:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39c3ddf8615ccc5fb54ef70dfb762ea5a022b87e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

39c3ddf by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of EAP identity.
    
    There's no guarantee that the identity is a string whose first character
    is a prefix indicating the type of identity; only display it as a prefix
    if it's one of the known types.  We really may need some other mechanism
    to determine how to parse the identity, perhaps based on what the
    protocol layers below it are.
    
    Put back the display of the full string in one case where that was
    inadvertently removed.
    
    Change-Id: I2e3324f964fa25ebd7065ddb0de82ffae6597509
    Reviewed-on: https://code.wireshark.org/review/17764
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ede1af2   eap: make eap_identity_prefix a numeric item
    adds  39c3ddf   Fix handling of EAP identity.


Summary of changes:
 epan/dissectors/packet-eap.c |   67 +++++++++++++++++++++++++++++-------------
 1 file changed, 47 insertions(+), 20 deletions(-)