Wireshark-commits: [Wireshark-commits] master-2.2 dfa8729: Qt: Argument vector fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Sep 2016 18:10:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dfa87296ab89407feb136d68f82755fbe9e9c923
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

dfa8729 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Argument vector fixups.
    
    In wireshark-qt.cpp we have two "argv" variables, one that we pass to
    QCoreApplication (which it then corrupts irreversibly on Windows if you
    pass it multibyte characters), and one that we convert to UTF-8 and use
    normally.
    
    Name the throwaway argument vector "qt_argv". Name ours "argv", which is
    the traditional and less error-prone name.
    
    Bug: 12900
    Change-Id: Idd80b9f779f36ffe977465afd623d320212f92b1
    Reviewed-on: https://code.wireshark.org/review/17723
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit f317a2b304f50392b360ac95de995459a24c3b7d)
    Reviewed-on: https://code.wireshark.org/review/17739
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  cb5a292   ssl-utils: fix buffer overrun (read) with AEAD cipher suites
    adds  dfa8729   Qt: Argument vector fixups.


Summary of changes:
 wireshark-qt.cpp |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)