Wireshark-commits: [Wireshark-commits] master e4aa7be: ZigBee: Fix reassembly of APS fragments.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Sep 2016 13:01:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4aa7be94943369c7f8119d7f15135d3f07b56df
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e4aa7be by Kenneth Soerensen (knnthsrnsn@xxxxxxxxx):

    ZigBee: Fix reassembly of APS fragments.
    
    The unsigned variable num_blocks was initialized to -1. Which caused the
    dissector to set the total length to 4294967295 fragments when the second
    fragment was processed. This made the dissector unable to reassemble data
    made of more than two fragments.
    
    Change-Id: I120af090ed29ac73a1fa699bea2bfc91798ef92b
    Reviewed-on: https://code.wireshark.org/review/17712
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  663031e   ssl-utils: fix -Wshorten-64-to-32 and other warnings
    adds  e4aa7be   ZigBee: Fix reassembly of APS fragments.


Summary of changes:
 epan/dissectors/packet-zbee-aps.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)