Wireshark-commits: [Wireshark-commits] master-2.2 a6bd069: diam_dict.l: remove use of strdup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 2 Sep 2016 19:23:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6bd069e0c9f4017f66ab4b956b636a869b7cd5c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

a6bd069 by Peter Wu (peter@xxxxxxxxxxxxx):

    diam_dict.l: remove use of strdup
    
    This should fix crashes on Windows, _strdup should not be mixed with
    g_free. This was only uncovered in v2.3.0rc0-474-ga04b6fc, before that
    ddict_free was never called.
    
    Change-Id: I34111385c82715de70fb42fe44b99b89e132a374
    Reviewed-on: https://code.wireshark.org/review/17423
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 5c2d82a6c24a06da0132fb7bd493ce4e58594f0d)
    Reviewed-on: https://code.wireshark.org/review/17466
    

Actions performed:

    from  44e097d   xml: fix some memleaks
    adds  a6bd069   diam_dict.l: remove use of strdup


Summary of changes:
 epan/diam_dict.l |   22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)