Wireshark-commits: [Wireshark-commits] master c7ca0e8: dissector ISAKMP IKEv2: fixed bug with libgc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Aug 2016 10:08:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c7ca0e88df468989647fc272a798bcd038084d99
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c7ca0e8 by Michał Skalski (mskalski13@xxxxxxxxx):

    dissector ISAKMP IKEv2: fixed bug with libgcrypt-1.6.x and AEAD ciphers
    
    IKEv2: 
    Fixed bug with AEAD ciphers with 8- and 12-byte length ICVs and
    libgcrypt 1.6.x - gcry_cipher_checktag() returned INVALID_LENGTH.
    Fixed for merged changeset https://code.wireshark.org/review/17078
    
    
    Added support for verification of encrypted data with HMAC_MD5_128
    [RFC4595] and HMAC_SHA1_160 [RFC4595] integrity algorithms
    
    Added IKEv2 decryption suite for few combinations of encryption and
    integrity algorithms: 3DES-CBC/SHA1_160, AES-128-CCM-12, AES-128-CCM-12
    (using CTR mode), AES-192-CTR/SHA2-512, AES-256-CBC/SHA2-256,
    AES-256-CCM-16, AES-256-GCM-16, AES-256-GCM-8
    
    
    Change-Id: Ic564b25f1fd41e913c605322b7b8aa030cf90ddf
    Reviewed-on: https://code.wireshark.org/review/17213
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  8d7aba1   IEEE 802.15.4:dissecting header & payload information elements used by 6tisch.
    adds  c7ca0e8   dissector ISAKMP IKEv2: fixed bug with libgcrypt-1.6.x and AEAD ciphers


Summary of changes:
 epan/dissectors/packet-isakmp.c                |   51 ++++++++--
 test/captures/ikev2-decrypt-3des-sha1_160.pcap |  Bin 0 -> 1860 bytes
 test/captures/ikev2-decrypt-aes128ccm12-2.pcap |  Bin 0 -> 1416 bytes
 test/captures/ikev2-decrypt-aes128ccm12.pcap   |  Bin 0 -> 1432 bytes
 test/captures/ikev2-decrypt-aes192ctr.pcap     |  Bin 0 -> 1512 bytes
 test/captures/ikev2-decrypt-aes256cbc.pcapng   |  Bin 0 -> 1792 bytes
 test/captures/ikev2-decrypt-aes256ccm16.pcapng |  Bin 0 -> 1728 bytes
 test/captures/ikev2-decrypt-aes256gcm16.pcap   |  Bin 0 -> 1448 bytes
 test/captures/ikev2-decrypt-aes256gcm8.pcap    |  Bin 0 -> 1400 bytes
 test/config/ikev2_decryption_table.tmpl        |   10 ++
 test/suite-decryption.sh                       |  124 ++++++++++++++++++++++++
 11 files changed, 176 insertions(+), 9 deletions(-)
 create mode 100644 test/captures/ikev2-decrypt-3des-sha1_160.pcap
 create mode 100644 test/captures/ikev2-decrypt-aes128ccm12-2.pcap
 create mode 100644 test/captures/ikev2-decrypt-aes128ccm12.pcap
 create mode 100644 test/captures/ikev2-decrypt-aes192ctr.pcap
 create mode 100644 test/captures/ikev2-decrypt-aes256cbc.pcapng
 create mode 100644 test/captures/ikev2-decrypt-aes256ccm16.pcapng
 create mode 100644 test/captures/ikev2-decrypt-aes256gcm16.pcap
 create mode 100644 test/captures/ikev2-decrypt-aes256gcm8.pcap
 create mode 100644 test/config/ikev2_decryption_table.tmpl