Wireshark-commits: [Wireshark-commits] master-2.2 32ac8d2: wmem_array_index() returns a *pointer* t
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Aug 2016 07:39:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32ac8d225ae08677c4ac6047878c137ac703c045
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

32ac8d2 by Guy Harris (guy@xxxxxxxxxxxx):

    wmem_array_index() returns a *pointer* to the array element.
    
    The array is an array of guint8 *'s that point to strings;
    wmem_array_index() doesn't return a pointer to the string, it returns a
    pointer to a pointer to the string, and you have to dereference the
    result of the wmem_array_index() call to get a pointer to the string.
    
    Change-Id: I8c7b3320f0979b01383ad255419c21cdeb7df4c7
    Reviewed-on: https://code.wireshark.org/review/17221
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit e83bdc67cc413c25321ae75792a2c92d55b6e544)
    Reviewed-on: https://code.wireshark.org/review/17222
    

Actions performed:

    from  e388dd0   Get rid of trailing blank line.
    adds  32ac8d2   wmem_array_index() returns a *pointer* to the array element.


Summary of changes:
 epan/dissectors/packet-pcp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)