Wireshark · Wireshark-commits: [Wireshark-commits] master 9902117: TCPROS - Protocol dissector improvements

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9902117f1a2eb47bb5bd1a0323a3d3891ef17d5b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9902117 by Guillaume Autran (gautran@xxxxxxxxxxxx):

    TCPROS - Protocol dissector improvements
    
     - Added specific dissector for ROS Clock messages
     - Added dissector heuristics
     - Improve ROS traffic detection
    
    Problems to resolve:
     - Some topics are mistaken for Clock messages. These includes the wheel encoder topic.
     - ROS Services are not detected.
     - Ideally, the TF topic should be dissected as it is a very common topic
    
    Bug: 12749
    Change-Id: I14255cbb42ae36b7e39f64dc1a5c6efffe19c8b1
    Reviewed-on: https://code.wireshark.org/review/17086/
    Reviewed-on: https://code.wireshark.org/review/17086
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0a9e842   COAP: ensure that key_token is always initialized
    adds  9902117   TCPROS - Protocol dissector improvements


Summary of changes:
 AUTHORS.src                     |    2 +-
 epan/dissectors/packet-tcpros.c |  219 +++++++++++++++++++++++++++++++++------
 2 files changed, 187 insertions(+), 34 deletions(-)