Wireshark-commits: [Wireshark-commits] master-2.0 8cd0d5b: Add a preference to byte-swap the CAN ID
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Aug 2016 23:23:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8cd0d5b16002efb1de24021b1e02cfeccb782980
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

8cd0d5b by Guy Harris (guy@xxxxxxxxxxxx):

    Add a preference to byte-swap the CAN ID field.
    
    This can be useful when dealing with 1) captures from versions of
    libpcap without the bug fix to use DLT_CAN_SOCKETCAN_HOSTENDIAN when
    appropriate and 2) DLT_CAN_SOCKETCAN_HOSTENDIAN captures if processed by
    a machine with a different byte order from the capturing machine with
    software that doesn't properly put the field into host byte order when
    reading and writing.
    
    Change-Id: I0cabc01024065807867eaeccc9812c5d60bd060d
    Reviewed-on: https://code.wireshark.org/review/17189
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  150c13d   NLM: fix dissection of NLM_FREE_ALL message
    adds  8cd0d5b   Add a preference to byte-swap the CAN ID field.


Summary of changes:
 epan/dissectors/packet-socketcan.c |   35 ++++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 15 deletions(-)