Wireshark-commits: [Wireshark-commits] master d2ee571: dissector ISAKMP: Added decryption using AES
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Aug 2016 11:13:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2ee571df2b31079f4b4f0e1915edc76f9a5dcff
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d2ee571 by Michał Skalski (mskalski13@xxxxxxxxx):

    dissector ISAKMP: Added decryption using AES-GCM, AES-CCM and AES-CTR
    
    Added support for decryption of IKEv2 packets encrypted with PAED or CTR
    cipher mode.
    Verification of integrity requires libgcrypt 1.6.0 or later. If it is
    not the case, only decryption is performed
    Can easily be extended to other ciphers supported by libgcrypt.
    
    NOTE: There is long-term bug in handling UAT for IKEv2 - any change
    resulting in change count of IKEv2 UAT entries causes crash when
    matching key from UAT is found.
    Crash does not occur when UAT is read from user prefs file.
    I observed this bug also on stock 1.10.6 version from Ubuntu 14.04 LTS
    
    I have no knowledge, how to fix it.
    
    Change-Id: Ibdab979b5959eb561635cbcb446e17138baca87b
    Reviewed-on: https://code.wireshark.org/review/17078
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5b57c79   RTPS: Added locator information to the parameter tree.
    adds  d2ee571   dissector ISAKMP: Added decryption using AES-GCM, AES-CCM and AES-CTR


Summary of changes:
 epan/dissectors/packet-isakmp.c |  289 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 275 insertions(+), 14 deletions(-)