Wireshark-commits: [Wireshark-commits] master-2.2 db6718d: Allocate all the wmem maps with epan sco
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 15 Aug 2016 00:05:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db6718dc4668f90a95d71134f2018c25f94af849
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

db6718d by Guy Harris (guy@xxxxxxxxxxxx):

    Allocate all the wmem maps with epan scope.
    
    That doesn't seem to affect the performance negatively (or
    positively...) to any noticeable degree with my simple "run tshark under
    the time command with an empty file" tests, and it does appear to reduce
    the amount of memory that valgrind thinks is leaked.
    
    All the other maps were already allocated with epan scope, so do that
    with these as well.
    
    Change-Id: Ib5ee85c8cf025e53455564a67cd1adbf28b47f78
    Ping-Bug: 12656
    Reviewed-on: https://code.wireshark.org/review/17040
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit c0f24bdf6c255068d3de386b00c1d0db3041a98f)
    Reviewed-on: https://code.wireshark.org/review/17054
    

Actions performed:

    from  ac6c49b   [Automatic update for 2016-08-14]
    adds  db6718d   Allocate all the wmem maps with epan scope.


Summary of changes:
 epan/addr_resolv.c |   19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)