Wireshark-commits: [Wireshark-commits] master c0f24bd: Allocate all the wmem maps with epan scope.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 13 Aug 2016 23:42:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0f24bdf6c255068d3de386b00c1d0db3041a98f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c0f24bd by Guy Harris (guy@xxxxxxxxxxxx):

    Allocate all the wmem maps with epan scope.
    
    That doesn't seem to affect the performance negatively (or
    positively...) to any noticeable degree with my simple "run tshark under
    the time command with an empty file" tests, and it does appear to reduce
    the amount of memory that valgrind thinks is leaked.
    
    All the other maps were already allocated with epan scope, so do that
    with these as well.
    
    Change-Id: Ib5ee85c8cf025e53455564a67cd1adbf28b47f78
    Ping-Bug: 12656
    Reviewed-on: https://code.wireshark.org/review/17040
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  631139b   LLDP: Add Avaya IP Phone OUI Subtypes
    adds  c0f24bd   Allocate all the wmem maps with epan scope.


Summary of changes:
 epan/addr_resolv.c |   19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)