Wireshark-commits: [Wireshark-commits] master 620f572: netlink: fully dissect NLA Type, add length
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 13 Aug 2016 21:43:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=620f5721b176ab4cd0cd87ec618925c91664f2ee
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

620f572 by Peter Wu (peter@xxxxxxxxxxxxx):

    netlink: fully dissect NLA Type, add length restriction
    
    NLA types consist of a type and two flags, add new fields for this.
    
    Add a new parameter to restrict the data consumed by the
    dissect_netlink_attributes function, this is needed when implementing
    nested attributes using another call to this function. This also avoids
    adding padding to the payload and matches the comment in
    include/uapi/linux/netlink.h (Linux 4.7).
    
    Change-Id: I34dbfa466081b6c6c4580941aff568bd120b4210
    Reviewed-on: https://code.wireshark.org/review/17030
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  5ae7076   OUI: Add 0x000142 Cisco to oui_vals
    adds  620f572   netlink: fully dissect NLA Type, add length restriction


Summary of changes:
 epan/dissectors/packet-netlink-netfilter.c |    8 ++--
 epan/dissectors/packet-netlink-route.c     |    2 +-
 epan/dissectors/packet-netlink-sock_diag.c |   16 +++----
 epan/dissectors/packet-netlink.c           |   70 ++++++++++++++++++++--------
 epan/dissectors/packet-netlink.h           |    6 ++-
 5 files changed, 69 insertions(+), 33 deletions(-)