Wireshark-commits: [Wireshark-commits] master-2.0 4451dc8: qnet6: fix display of MAC addresses and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Aug 2016 20:41:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4451dc84d4fc46c92faa82a5bffadb0cbf1f925c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4451dc8 by Peter Wu (peter@xxxxxxxxxxxxx):

    qnet6: fix display of MAC addresses and avoid overflow
    
    The MAC address is binary data, do not use tvb_get_string_enc since it
    substituted some bytes by a Unicode replacement character. Use FT_ETHER
    instead of FT_STRING to fix the display.
    
    Bug: 11850
    Change-Id: I3f02cfa13e8fccc18a199e4e293580c183eeddd1
    Reviewed-on: https://code.wireshark.org/review/16965
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1396f6ad555178f6b81cc1a65f9cb37b2d99aebf)
    Reviewed-on: https://code.wireshark.org/review/17001
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  6e83c20   Revert "docbook: add tip about recommended Qt version."
    adds  4451dc8   qnet6: fix display of MAC addresses and avoid overflow


Summary of changes:
 epan/dissectors/packet-qnet6.c |   53 +++++++++++++++++++++++-----------------
 1 file changed, 30 insertions(+), 23 deletions(-)