Wireshark-commits: [Wireshark-commits] master-2.0 1c99d80: Use -r rather than -i for the "via stdin
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c99d806f61530f7753d07fd0e110c4463e67ebc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
1c99d80 by Guy Harris (guy@xxxxxxxxxxxx):
Use -r rather than -i for the "via stdin" tests.
TShark, at least when running in one-pass mode, now supports reading
from the standard input if the file format is one that *can* be read
purely sequentially; both pcap and pcapng can be read purely
sequentially (unlike, for example, Microsoft Network Monitor format,
where you have to read the frame table, at the end of the file, before
you can read the frames, meaning you have to seek backwards, which you
can't do on a pipe).
Using -r 1) tests the "read from standard input" path, which we should
do in versions that support it, and 2) means we can check whether, for
the crashes we're seeing on 32-bit Windows 8.1, it's a problem with
reading from the standard input in general, or just a problem with
*capturing* from the standard input.
Change-Id: I67da34de43f47dd8c63fa2f2072be41148cfe5a7
Reviewed-on: https://code.wireshark.org/review/16968
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit 8a141febc849c36dc40d4da2a39318f8f8856091)
Reviewed-on: https://code.wireshark.org/review/16970
Actions performed:
from c0150ff [Automatic update for 2016-08-07]
adds 1c99d80 Use -r rather than -i for the "via stdin" tests.
Summary of changes:
test/suite-fileformats.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
