Wireshark · Wireshark-commits: [Wireshark-commits] master 8a141fe: Use -r rather than -i for the "via stdin" tests.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a141febc849c36dc40d4da2a39318f8f8856091
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8a141fe by Guy Harris (guy@xxxxxxxxxxxx):

    Use -r rather than -i for the "via stdin" tests.
    
    TShark, at least when running in one-pass mode, now supports reading
    from the standard input if the file format is one that *can* be read
    purely sequentially; both pcap and pcapng can be read purely
    sequentially (unlike, for example, Microsoft Network Monitor format,
    where you have to read the frame table, at the end of the file, before
    you can read the frames, meaning you have to seek backwards, which you
    can't do on a pipe).
    
    Using -r 1) tests the "read from standard input" path, which we should
    do in versions that support it, and 2) means we can check whether, for
    the crashes we're seeing on 32-bit Windows 8.1, it's a problem with
    reading from the standard input in general, or just a problem with
    *capturing* from the standard input.
    
    Change-Id: I67da34de43f47dd8c63fa2f2072be41148cfe5a7
    Reviewed-on: https://code.wireshark.org/review/16968
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5cfb33f   DHCPv6: Update Options Codes
    adds  8a141fe   Use -r rather than -i for the "via stdin" tests.


Summary of changes:
 test/suite-fileformats.sh |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)