Wireshark-commits: [Wireshark-commits] master ef8098c: netlink: dissect errors and more flags, impr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 7 Aug 2016 21:05:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef8098cb3778e2c93c4c235528e15b9fd849fb53
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ef8098c by Peter Wu (peter@xxxxxxxxxxxxx):

    netlink: dissect errors and more flags, improve display and help
    
    Print "Protocol-specific" instead of "Unknown (0x0016)" for the type
    since its interpretation depend on the subprotocol.
    
    Dissect struct nlmsgerr (refactor and reuse the header dissection code).
    Dissect Dump interrupted and Dump filtered flags.
    
    Adjust field descriptions and value_string based on the netlink(7)
    manual and linux/netlink.h. Display Flags as hex instead of decimal.
    Expanded inline tabs, renamed netlink.hdr_flags.match_all to
    netlink.hdr_flags.match for consistency.
    
    Change-Id: If2b5c8d2b68fd94e70d1d8b98e63171b42b0d65c
    Reviewed-on: https://code.wireshark.org/review/16932
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  bad783b   Qt: add initializers (CID 1328485).
    adds  ef8098c   netlink: dissect errors and more flags, improve display and help


Summary of changes:
 epan/dissectors/packet-netlink.c |  201 ++++++++++++++++++++++++--------------
 epan/dissectors/packet-netlink.h |    2 +
 2 files changed, 128 insertions(+), 75 deletions(-)