Wireshark-commits: [Wireshark-commits] master 9057699: logcat-text: add cleanup function.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Aug 2016 00:24:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=90576991275923eef4daa017c9e72df2e6930c1e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9057699 by Dario Lombardo (lomato@xxxxxxxxx):

    logcat-text: add cleanup function.
    
    Found by valgrind.
    
    ==23399== 209 (40 direct, 169 indirect) bytes in 1 blocks are definitely lost in loss record 2,431 of 2,696
    ==23399==    at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==23399==    by 0xAAA2780: g_malloc0 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.1)
    ==23399==    by 0xAAB0760: g_regex_new (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.1)
    ==23399==    by 0x6B03162: proto_register_logcat_text (packet-logcat-text.c:373)
    ==23399==    by 0x71BA16D: register_all_protocols (register.c:2881)
    ==23399==    by 0x7296E67: proto_init (proto.c:529)
    ==23399==    by 0x7272A76: epan_init (epan.c:128)
    ==23399==    by 0x1160F2: main (tshark.c:804)
    
    Change-Id: Ia47a4371a62eaadcdc8613d35030792d57e7f9dc
    Reviewed-on: https://code.wireshark.org/review/16881
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6b4e970   kafka: remove unused assignment.
    adds  9057699   logcat-text: add cleanup function.


Summary of changes:
 epan/dissectors/packet-logcat-text.c |   34 ++++++++++++++++++++++++++--------
 1 file changed, 26 insertions(+), 8 deletions(-)